From 9874d5983b296a8ab949cf5136eec4d0e5cf7ac0 Mon Sep 17 00:00:00 2001
From: Blitblank <pmcgeee03@gmail.com>
Date: Thu, 25 Dec 2025 23:00:13 -0600
Subject: [PATCH] small ui update

---
 src/synth/Synth.cpp           |  2 ++
 src/ui/MainWindow.ui          | 26 +++++++--------
 src/ui/widgets/SmartSlider.ui | 60 +++++++++++++++++++++++++++++------
 3 files changed, 66 insertions(+), 22 deletions(-)

diff --git a/src/synth/Synth.cpp b/src/synth/Synth.cpp
index 052046b..b59bb2c 100644
--- a/src/synth/Synth.cpp
+++ b/src/synth/Synth.cpp
@@ -74,6 +74,8 @@ void Synth::process(float* out, uint32_t nFrames, uint32_t sampleRate) {
         // process all envelopes
         gainEnvelope_.set(getParam(ParamId::Osc1VolumeEnvA), getParam(ParamId::Osc1VolumeEnvD), getParam(ParamId::Osc1VolumeEnvS), getParam(ParamId::Osc1VolumeEnvR));
         float gain = gainEnvelope_.process();
+        // TODO: envelope is shared between all notes so this sequence involves a note change but only one envelope attack:
+        // NOTE_A_ON > NOTE_B_ON > NOTE_A_OFF and note B starts playing part-way through note A's envelope 
 
         // skip if no active notes
         if(!gainEnvelope_.isActive()) {
diff --git a/src/ui/MainWindow.ui b/src/ui/MainWindow.ui
index 7da2b67..75e7a27 100644
--- a/src/ui/MainWindow.ui
+++ b/src/ui/MainWindow.ui
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>800</width>
+    <width>739</width>
     <height>605</height>
    </rect>
   </property>
@@ -38,10 +38,10 @@
    <widget class="SmartSlider" name="sliderGainR" native="true">
     <property name="geometry">
      <rect>
-      <x>580</x>
+      <x>480</x>
       <y>180</y>
-      <width>171</width>
-      <height>321</height>
+      <width>120</width>
+      <height>300</height>
      </rect>
     </property>
     <property name="autoFillBackground">
@@ -51,10 +51,10 @@
    <widget class="SmartSlider" name="sliderGainA" native="true">
     <property name="geometry">
      <rect>
-      <x>40</x>
+      <x>120</x>
       <y>180</y>
-      <width>171</width>
-      <height>321</height>
+      <width>120</width>
+      <height>300</height>
      </rect>
     </property>
     <property name="autoFillBackground">
@@ -64,10 +64,10 @@
    <widget class="SmartSlider" name="sliderGainD" native="true">
     <property name="geometry">
      <rect>
-      <x>220</x>
+      <x>240</x>
       <y>180</y>
-      <width>171</width>
-      <height>321</height>
+      <width>120</width>
+      <height>300</height>
      </rect>
     </property>
     <property name="autoFillBackground">
@@ -77,10 +77,10 @@
    <widget class="SmartSlider" name="sliderGainS" native="true">
     <property name="geometry">
      <rect>
-      <x>400</x>
+      <x>360</x>
       <y>180</y>
-      <width>171</width>
-      <height>321</height>
+      <width>120</width>
+      <height>300</height>
      </rect>
     </property>
     <property name="autoFillBackground">
diff --git a/src/ui/widgets/SmartSlider.ui b/src/ui/widgets/SmartSlider.ui
index 4ff7028..32eb06b 100644
--- a/src/ui/widgets/SmartSlider.ui
+++ b/src/ui/widgets/SmartSlider.ui
@@ -6,22 +6,34 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>168</width>
-    <height>298</height>
+    <width>120</width>
+    <height>300</height>
    </rect>
   </property>
+  <property name="sizePolicy">
+   <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
+    <horstretch>0</horstretch>
+    <verstretch>0</verstretch>
+   </sizepolicy>
+  </property>
   <property name="windowTitle">
    <string>Form</string>
   </property>
   <widget class="QSlider" name="slider">
    <property name="geometry">
     <rect>
-     <x>70</x>
+     <x>50</x>
      <y>90</y>
      <width>16</width>
      <height>160</height>
     </rect>
    </property>
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Fixed" vsizetype="Preferred">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
    <property name="orientation">
     <enum>Qt::Orientation::Vertical</enum>
    </property>
@@ -32,32 +44,50 @@
   <widget class="QDoubleSpinBox" name="spinMin">
    <property name="geometry">
     <rect>
-     <x>40</x>
+     <x>20</x>
      <y>260</y>
      <width>82</width>
      <height>24</height>
     </rect>
    </property>
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
   </widget>
   <widget class="QDoubleSpinBox" name="spinMax">
    <property name="geometry">
     <rect>
-     <x>40</x>
+     <x>20</x>
      <y>60</y>
      <width>82</width>
      <height>24</height>
     </rect>
    </property>
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
   </widget>
   <widget class="QDoubleSpinBox" name="spinValue">
    <property name="geometry">
     <rect>
-     <x>40</x>
-     <y>10</y>
+     <x>20</x>
+     <y>20</y>
      <width>82</width>
      <height>31</height>
     </rect>
    </property>
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
    <property name="font">
     <font>
      <pointsize>12</pointsize>
@@ -67,12 +97,18 @@
   <widget class="Line" name="line">
    <property name="geometry">
     <rect>
-     <x>20</x>
+     <x>0</x>
      <y>10</y>
      <width>20</width>
      <height>271</height>
     </rect>
    </property>
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Fixed" vsizetype="Preferred">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
    <property name="orientation">
     <enum>Qt::Orientation::Vertical</enum>
    </property>
@@ -80,12 +116,18 @@
   <widget class="Line" name="line_2">
    <property name="geometry">
     <rect>
-     <x>120</x>
+     <x>100</x>
      <y>10</y>
      <width>20</width>
      <height>271</height>
     </rect>
    </property>
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Fixed" vsizetype="Preferred">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
    <property name="orientation">
     <enum>Qt::Orientation::Vertical</enum>
    </property>