cleanup include paths

CMakeLists.txt

@@ -90,7 +90,9 @@ qt_add_executable(metabolus
 set_target_properties(metabolus PROPERTIES AUTOUIC ON)
 
 target_include_directories(metabolus PRIVATE
+    ${CMAKE_SOURCE_DIR}/src/
     ${CMAKE_SOURCE_DIR}/src/ui
+    ${CMAKE_SOURCE_DIR}/src/synth
     ${CMAKE_SOURCE_DIR}/src/ui/widgets
 )
 

README.md

@@ -48,11 +48,11 @@ Linux: GCC
 
 Clone repository
 ```PowerShell
-git clone https://github.com/Blitblank/metabalus.git --recursive
+git clone https://git.vxbard.net/homeburger/metabalus.git --recursive
 ```
 or if you forgot to --recursive:
 ```PowerShell
-git clone https://github.com/Blitblank/metabalus.git
+git clone https://git.vxbard.net/homeburger/metabalus.git
 git submodule update --init --recursive
 ```
 \

src/main.cpp

@@ -16,6 +16,7 @@ int main(int argc, char *argv[]) {
     window.show();
 
     // TODO: logging
+    // TODO: separate app from the window
     // i made a good debug filtering setup in ouros so could probably improt that into this project
     
     int status = app.exec(); // app execution; blocks until window close

src/synth/Oscillator.h

@@ -11,6 +11,8 @@
     #define M_PI 3.14159265358979323846
 #endif
 
+// TODO: if the amount of notes per octave is changed via config then this constant needs to be calculated at startup
+// as SYNTH_Xth_ROOT_TWO
 #define SYNTH_TWELFTH_ROOT_TWO 1.05946309435929526463
 
 // TODO: you get it, also in a yml config

src/synth/Voice.cpp

@@ -101,7 +101,7 @@ float Voice::process(float* params, bool& scopeTrigger) {
 
     // TODO: implement controls for noise
     //float scale = static_cast<float>(rand()) / static_cast<float>(RAND_MAX); // Range [0.0, 1.0]
-    //float noise = -1.0f + 2.0f * scale;
+    //float noise = (-1.0f + 2.0f * scale) * 0.2f;
     // these values didn't sound good so I commented them out before I get controls for them
 
     // mix oscillators

src/ui/MainWindow.cpp

@@ -59,7 +59,6 @@ MainWindow::MainWindow(QWidget *parent) :
         }
     }
     
-
     // rogue sliders, TODO: clean these up in a package
     connect(ui_->sliderMasterOctave, &SmartSlider::valueChanged,
     this, [this](float value) {
@@ -157,6 +156,7 @@ void MainWindow::onResetClicked() {
 
     // TODO: clean these up, maybe put them in a package like the envelope generators (it'll help encapsulate the int-snapping business)
     // what I might do is make a variable-length slider-package object
+    // TODO: the oscillator things also need an amplitude parameter too 
     YAML::Node masterNode = configRoot["MasterPitchOffset"];
     YAML::Node osc1Node = configRoot["Osc1PitchOffset"];
     YAML::Node osc2Node = configRoot["Osc2PitchOffset"];

src/ui/MainWindow.h

@@ -4,9 +4,9 @@
 #include <QMainWindow>
 #include <QKeyEvent>
 
-#include "../ConfigInterface.h"
-#include "../synth/AudioEngine.h"
-#include "../MidiController.h"
+#include "ConfigInterface.h"
+#include "synth/AudioEngine.h"
+#include "MidiController.h"
 
 QT_BEGIN_NAMESPACE
 namespace Ui { class MainWindow; }